fix: Use ruamel.yaml instead of pyyaml #651
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Diwank Singh Tomer <[email protected]>
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
👍 Looks good to me! Reviewed everything up to 0854ead in 26 seconds
More details
- Looked at
253lines of code in12files - Skipped
3files when reviewing. - Skipped posting
2drafted comments based on config settings.
1. agents-api/agents_api/activities/utils.py:52
- Draft comment:
Ensure thatyaml.loadis used correctly with the newyamlmodule fromruamel.yaml. TheCSafeLoaderis no longer applicable. - Reason this comment was not posted:
Marked as duplicate.
2. agents-api/agents_api/activities/utils.py:75
- Draft comment:
Ensure thatyaml.loadandyaml.dumpare used correctly with the newyamlmodule fromruamel.yaml. TheCSafeLoaderandCSafeDumperare no longer applicable. - Reason this comment was not posted:
Comment did not seem useful.
Workflow ID: wflow_ftZ0jnGTvAwowlnT
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Diwank Singh Tomer [email protected]
Important
Replace
pyyamlwithruamel.yamlfor YAML processing and perform minor code cleanups.pyyamlwithruamel.yamlinutils.py,template.py, androuters/tasks/router.py.yaml.pyincommon/utilsto definedumpandloadfunctions usingruamel.yaml.excecute_api_call.pyandexecute_system.py.Nonecomparison inexecute_system.py.update_execution.py.pyyamland addruamel-yamlinpyproject.toml.This description was created by
for 0854ead. It will automatically update as commits are pushed.